Skip to content

Define nullability @Contract for quote and getFilename in StringUtils #34896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2025
Merged

Define nullability @Contract for quote and getFilename in StringUtils #34896

merged 1 commit into from
May 21, 2025

Conversation

snicoll
Copy link
Member

@snicoll snicoll commented May 14, 2025 •
edited
Loading

This currently fails

if (StringUtils.hasLength(location)) {
	String filename = StringUtils.stripFilenameExtension(StringUtils.getFilename(location));
}

@snicoll
Polish nullability contract of StringUtils
841f358 
Signed-off-by: Stéphane Nicoll <stephane.nicoll@broadcom.com>
@snicoll snicoll force-pushed the polish-20250414 branch from 0c75038 to 841f358 Compare May 14, 2025 12:23
@sbrannen sbrannen added the in: core Issues in core modules (aop, beans, core, context, expression) label May 14, 2025
@sbrannen sbrannen self-assigned this May 20, 2025
@sbrannen sbrannen added this to the 6.2.8 milestone May 20, 2025
@sbrannen sbrannen changed the title Polish nullability contract of StringUtils Define nullability contracts for quote and getFilename in StringUtils May 21, 2025
@sbrannen sbrannen modified the milestones: 6.2.8, 7.0.0-M6 May 21, 2025
@sbrannen sbrannen changed the title Define nullability contracts for quote and getFilename in StringUtils Define nullability @Contract for quote and getFilename in StringUtils May 21, 2025
@sbrannen sbrannen merged commit 9d3779d into spring-projects:main May 21, 2025
2 of 3 checks passed
@sbrannen sbrannen added the type: enhancement A general enhancement label May 22, 2025
@sbrannen sbrannen mentioned this pull request May 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sbrannen sbrannen

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Milestone
7.0.0-M6
Development

Successfully merging this pull request may close these issues.
2 participants
@snicoll @sbrannen